Skip to content

Add to irrelevant_files list #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Add to irrelevant_files list #217

merged 6 commits into from
Mar 12, 2025

Conversation

ayefimov-1
Copy link
Contributor

Add to irrelevant_files list for graphing, logging and autoscaling jobs

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 5

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

1 similar comment
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

mapping values are not allowed in this context
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 60, column 25

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

expected a dictionary @ data['irrelevant-files'][0]

The problem appears in the the "functional-logging-tests-osp18" job stanza:

job:
name: functional-logging-tests-osp18
parent: telemetry-operator-multinode-logging
description: |
Run the logging functional tests on osp18
vars:
cifmw_extras:
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir }}/scenarios/centos-9/multinode-ci.yml"
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/telemetry-operator'].src_dir }}/ci/vars-logging.yml"
...

in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 47

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while constructing a mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 9
expected a mapping for merging, but found scalar
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 32, column 9

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

expected a dictionary @ data['irrelevant-files'][0]

The problem appears in the the "functional-logging-tests-osp18" job stanza:

job:
name: functional-logging-tests-osp18
parent: telemetry-operator-multinode-logging
description: |
Run the logging functional tests on osp18
vars:
cifmw_extras:
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir }}/scenarios/centos-9/multinode-ci.yml"
- "@{{ ansible_user_dir }}/{{ zuul.projects['github.com/openstack-k8s-operators/telemetry-operator'].src_dir }}/ci/vars-logging.yml"
...

in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 47

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 48, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 61, column 7

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 2, column 1
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 18, column 1

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while parsing a block mapping
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 49, column 5
did not find expected key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 62, column 7

Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add irrelevant files to the functional-tests-on-osp18 (i.e. autoscaling) job.

.zuul.yaml Outdated
@@ -75,7 +94,25 @@
roles:
- zuul: github.com/openstack-k8s-operators/ci-framework
required-projects: *required_projects
irrelevant-files: *irrelevant_files
irrelevant-files:
Copy link
Collaborator

@elfiesmelfie elfiesmelfie Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "files" is better than irrelevant-files, since it will result in a shorter list.
You could start with running these on any changes outside the roles/ dir + changes to the relevant role.

i.e. something like

files: 
- regex: 'roles/*'
  negate: true
- roles/telemetry_autoscaling
- ci/vars-metric-verification-tests.yml
# whatever other files from ci/ are relevant

source: https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.files
source: https://zuul-ci.org/docs/zuul/latest/project-config.html#regular-expressions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just learned that there's that negate option for file name matching

@mgirgisf
Copy link
Contributor

mgirgisf commented Mar 4, 2025

recheck

@mgirgisf
Copy link
Contributor

mgirgisf commented Mar 5, 2025

If irrelevant-files and files Are Present:
If a change affects files in files, the job runs.
If a change affects only files in irrelevant-files, the job does not run.
If a change affects both files and irrelevant-files, the job runs (because files takes precedence).

Anyway we have different files in both lists.
and The official Zuul documentation does not explicitly state that files takes precedence over irrelevant-files,
However, the relevant parts of the Zuul reference documentation mention:
files
If one or more regex patterns are supplied, the job will only run if at least one of the changed files matches one of the patterns.
irrelevant-files
If one or more regex patterns are supplied, the job will not run if all of the changed files match these patterns.
Thus, if a change includes both a files-matched and an irrelevant-files-matched file, the job must run because files specifies required files

This was referenced Mar 5, 2025
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 217,ff3754e134efea26757a3b714bbca38be56c68d2

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 217,640970dbd9853b1214f71ab5ebf843e5a677e8a2

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while scanning a simple key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 70, column 1
could not find expected ':'
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 71, column 21

@mgirgisf mgirgisf requested a review from elfiesmelfie March 7, 2025 08:33
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/28d4aa534b8c48ecb1d6155de0e22bad

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 49s
✔️ functional-tests-on-osp18 SUCCESS in 1h 21m 14s
functional-logging-tests-osp18 FAILURE in 1h 43m 17s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 08m 56s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 09m 11s

@ayefimov-1 ayefimov-1 mentioned this pull request Mar 7, 2025
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6b905906657e430dbc5e265b96235787

✔️ feature-verification-tests-noop SUCCESS in 5s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 15s
functional-tests-on-osp18 FAILURE in 1h 38m 09s
functional-logging-tests-osp18 FAILURE in 1h 39m 55s
functional-graphing-tests-osp18 FAILURE in 1h 39m 13s
functional-metric-verification-tests-osp18 FAILURE in 1h 40m 02s

* [ansible-lint] Update the config to ignore templates in task names
* [telemetry_logging] Update task names for XML reporting
* [common] Update task names for XML reporting
* [common] Update the name for the pod tests to include the
   status_string and namespace that the pod is running in

Add ceilometer_power_state to Metrics_verification test (#221)

* Add test Ceilometer_power_state

* Add the master_image to the zuul file

* Add the master_image to the zuul file

Add pod tests for Completed pods in the OpenStack namespace (#214)

* [ci] Add logging tests: completed pods in openstack namespace

* [ci] logging tests: update names for completed pods in openstack namespace

* [ci] logging: update typo on pod name

* [ci] Update pod list for completed status in openstack namespace

This repo-setup-edpm-deployment-openstack-edpm-ipam doesn't need to be
checked.

---------

Co-authored-by: Alex Yefimov <[email protected]>

[ci][logging] Add tests for services in the openstack namespace (#225)

Co-authored-by: Alex Yefimov <[email protected]>

[ci] Add endpoint tests to the logging job (#220)

* [ci] Add endpoint tests to the logging job

   The test checks for the various openstack endpoints that we expect to
exist

Co-authored-by: "Alex Yefimov <[email protected]>"

* [ci] Add vars/osp18_env to the logging playbook
   It contains the "openstack_cmd" var required for the endpoint tests

* [common] Add documentation and default for openstack_cmd

Fix kepler metrics tests (#224)

Kepler metrics tests were added in [1] though the merged commit
was not the correct one. This PR aplies changes from [2] that had
more correct code of the tests.

Fixes OSPRH-14029

[1] #193
[2] 0b5d856

Co-authored-by: Jaromír Wysoglad <[email protected]>

Change required projects

The projects should contain "github.com/" prefix.

Fix rabbitmq test

[zuul][graphing] Add the new dashboards to the test (#222)

* Add the new dashboards to zuul job

[ci] Add manifest tests to logging job (#228)

Co-authored-by: Alex Yefimov <[email protected]>

[telemetry_verify_metrics]: add openstack-network-exporter feature tests (#231)

* feature_tests: add openstack-network-exporter feature tests

Add tests for operator of openstack-network-exporter

Signed-off-by: Aaron T. Smith <[email protected]>
Co-authored-by: Aaron T. Smith <[email protected]>
Co-authored-by: Jaromír Wysoglad <[email protected]>

Add to irrelevant_files list for graphing, logging
and autoscaling jobs

Add to irrelevant_files list for graphing, logging
and autoscaling jobs

Add metrics verification tasks for power monitoring components (#193)

Move container image patch to post_ctlplane hook

Make autoscaling job voting

Add tasks to show queried metrics

[ci][logging] Move file tests to the compute nodes (#206)

[ci] logging test: fix typo 0->O (#205)

[ci][autoscaling] Add a note to the vars file for autoscaling (#215)

The note explains why os-net-config is skipped

Rename tasks for XML reporting (#181)

* [ansible-lint] Update the config to ignore templates in task names
* [telemetry_logging] Update task names for XML reporting
* [common] Update task names for XML reporting
* [common] Update the name for the pod tests to include the
   status_string and namespace that the pod is running in

Add files to the zuul jobs

Add files to the zuul jobs

uncomment zuul.yaml

Add ceilometer_power_state to Metrics_verification test (#221)

* Add test Ceilometer_power_state

* Add the master_image to the zuul file

* Add the master_image to the zuul file

Add pod tests for Completed pods in the OpenStack namespace (#214)

* [ci] Add logging tests: completed pods in openstack namespace

* [ci] logging tests: update names for completed pods in openstack namespace

* [ci] logging: update typo on pod name

* [ci] Update pod list for completed status in openstack namespace

This repo-setup-edpm-deployment-openstack-edpm-ipam doesn't need to be
checked.

---------

Co-authored-by: Alex Yefimov <[email protected]>

[ci][logging] Add tests for services in the openstack namespace (#225)

Co-authored-by: Alex Yefimov <[email protected]>

[ci] Add endpoint tests to the logging job (#220)

* [ci] Add endpoint tests to the logging job

   The test checks for the various openstack endpoints that we expect to
exist

Co-authored-by: "Alex Yefimov <[email protected]>"

* [ci] Add vars/osp18_env to the logging playbook
   It contains the "openstack_cmd" var required for the endpoint tests

* [common] Add documentation and default for openstack_cmd

Fix kepler metrics tests (#224)

Kepler metrics tests were added in [1] though the merged commit
was not the correct one. This PR aplies changes from [2] that had
more correct code of the tests.

Fixes OSPRH-14029

[1] #193
[2] 0b5d856

Co-authored-by: Jaromír Wysoglad <[email protected]>

Change required projects

The projects should contain "github.com/" prefix.

Fix rabbitmq test

[zuul][graphing] Add the new dashboards to the test (#222)

* Add the new dashboards to zuul job

Update .zuul.yaml

[ci] Add manifest tests to logging job (#228)

Co-authored-by: Alex Yefimov <[email protected]>

[telemetry_verify_metrics]: add openstack-network-exporter feature tests (#231)

* feature_tests: add openstack-network-exporter feature tests

Add tests for operator of openstack-network-exporter

Signed-off-by: Aaron T. Smith <[email protected]>
Co-authored-by: Aaron T. Smith <[email protected]>
Co-authored-by: Jaromír Wysoglad <[email protected]>

Add to irrelevant_files list for graphing, logging
and autoscaling jobs
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 217,12990730f3f0a3811a5c87109aee8728084fbbbd

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo infrawatch/feature-verification-tests on branch master. The
problem was:

while scanning a simple key
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 70, column 1
could not find expected ':'
in "infrawatch/feature-verification-tests/.zuul.yaml@master", line 71, column 21

ayefimov-1 and others added 2 commits March 12, 2025 08:59
* Add test for health monitoring feature

* Disable RBAC for KSM metrics

Co-authored-by: Martin Mágr <[email protected]>
Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#236 verifies that a change to README triggers only no-op
#223 verifies that changes to logging trigger the logging job

@ayefimov-1 ayefimov-1 merged commit e221d3e into master Mar 12, 2025
8 checks passed
@ayefimov-1 ayefimov-1 deleted the alexy_graphing branch March 12, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants